Skip to content

Add memspace "lowest latency" #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented May 22, 2024

This memspace is analogous to the 'highest bandwidth' memspace in its composition, but it focuses on the NUMA nodes with best latency.

Description

Contains changes from #408.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@kswiecicki kswiecicki force-pushed the memspace-lat branch 5 times, most recently from d7dbd34 to b1b66c1 Compare May 23, 2024 13:04
@lplewa
Copy link
Contributor

lplewa commented May 24, 2024

please rebase

@kswiecicki kswiecicki force-pushed the memspace-lat branch 3 times, most recently from 2123a45 to a424ae9 Compare May 27, 2024 08:14
@kswiecicki kswiecicki marked this pull request as ready for review May 27, 2024 09:19
@kswiecicki kswiecicki requested a review from a team as a code owner May 27, 2024 09:19
@kswiecicki kswiecicki force-pushed the memspace-lat branch 2 times, most recently from 0a43d58 to 3fb48d8 Compare May 31, 2024 09:59
@bratpiorka bratpiorka requested review from ldorau and lplewa May 31, 2024 15:41
@kswiecicki kswiecicki force-pushed the memspace-lat branch 2 times, most recently from 88f52fa to 865fd8a Compare June 3, 2024 12:38
@kswiecicki kswiecicki force-pushed the memspace-lat branch 2 times, most recently from 75ae6d3 to 3e0e2de Compare June 3, 2024 13:08
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ldorau
Copy link
Contributor

ldorau commented Jun 11, 2024

@kswiecicki Rebase please

This memspace is analogous to the 'highest bandwidth' memspace in its
composition, but it focuses on the NUMA nodes with best latency.
Those tests are skipped with GTEST_SKIP() when latency property
can't be queried (HMAT is not supported on the platform).
@bratpiorka bratpiorka merged commit 670398b into oneapi-src:main Jun 11, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants